Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loadstart/loadeddata/loadedmetadata events from GlobalEventHandlers #16925

Merged
merged 2 commits into from
Jul 23, 2022

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Jul 12, 2022

These are media element events already represented on HTMLMediaElement.

Add spec URLs for all media element events while in the area.

@foolip foolip requested a review from queengooborg July 12, 2022 07:56
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 12, 2022
@queengooborg queengooborg added the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Jul 12, 2022
@queengooborg
Copy link
Collaborator

Could we also take care of loadend in this PR?

@foolip
Copy link
Collaborator Author

foolip commented Jul 13, 2022

@queengooborg no, that's not a media element event, so I left it out.

@queengooborg
Copy link
Collaborator

Okay, then the MDN pages are wrong because there are numerous links and references to a loadend event on HTMLMediaElement.

@foolip
Copy link
Collaborator Author

foolip commented Jul 13, 2022

Yep :) There was a "loadend" event way back in some browser I think, but this event was abandoned.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

…dlers

These are media element events already represented on HTMLMediaElement.

Add spec URLs for all media element events while in the area.
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@queengooborg queengooborg removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Jul 23, 2022
@queengooborg queengooborg merged commit 0067bc2 into mdn:main Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants